AWARE SYSTEMS
TIFF and LibTiff Mail List Archive

Thread

2008.07.28 08:49 "[Tiff] CVS access", by Mateusz Łoskot
[...]
2008.08.13 05:32 "[Tiff] Re: tif_win32.c patch proposal (was: windows 64 bit build)", by Bob Friesenhahn
2008.09.04 14:12 "[Tiff] Re: tif_win32.c patch proposal", by Edward Lam
[...]

2008.09.04 14:12 "[Tiff] Re: tif_win32.c patch proposal", by Edward Lam

Seeing that there's been no movement on this patch, I've now submitted this under bug 1941 (http://bugzilla.maptools.org/show_bug.cgi?id=1941)

Cheers,

-Edward

If you can submit a tested patch, I will be happy to commit it.

Ok, here's a patch attached for discussion. The approach I previously mentioned ran into a slight snag. Once you've created an fd for a HANDLE, the C runtime library (CRT) takes ownership of it. Thus, when you call _close(fd), it closes the associated HANDLE as well. Plus, in _tiffCloseProc(), there was no way (that I found) to query the CRT to return the associated fd given the HANDLE. So in the end, I did something more drastic, albeit cleaner.

It seems that this approach is drastic enough that we should wait for some feedback from potentially impacted users before moving ahead with it.

Being more from the Unix mind-set than the Windows mind-set, I like your approach better than the approach which is currently used.