AWARE SYSTEMS
TIFF and LibTiff Mail List Archive

Thread

2010.05.20 08:23 "[Tiff] [PATCH] tiff2ps: Ability to specify document title", by Thomas Jarosch
2010.05.20 19:30 "Re: [Tiff] [PATCH] tiff2ps: Ability to specify document title", by Lee Howard
2010.05.21 07:59 "Re: [Tiff] [PATCH] tiff2ps: Ability to specify document title", by Thomas Jarosch
2010.06.18 17:46 "[Tiff] [PATCH] Build tif_win32.c on Windows except on Cygwin", by Adam Goode
2010.06.18 18:21 "Re: [Tiff] [PATCH] Build tif_win32.c on Windows except on Cygwin", by Bob Friesenhahn
2010.06.18 18:32 "Re: [Tiff] [PATCH] Build tif_win32.c on Windows except on Cygwin", by Adam Goode
2010.06.18 18:35 "Re: [Tiff] [PATCH] Build tif_win32.c on Windows except on Cygwin", by Adam Goode
2010.06.28 13:25 "Re: [Tiff] [PATCH] Build tif_win32.c on Windows except on Cygwin", by Edward Lam
2010.06.28 15:54 "Re: [Tiff] [PATCH] Build tif_win32.c on Windows except on Cygwin", by Bob Friesenhahn
2010.06.29 11:23 "Re: [Tiff] [PATCH] Build tif_win32.c on Windows except on Cygwin", by Andrey Kiselev
2010.06.29 13:46 "Re: [Tiff] [PATCH] Build tif_win32.c on Windows except on Cygwin", by Adam Goode

2010.06.29 13:46 "Re: [Tiff] [PATCH] Build tif_win32.c on Windows except on Cygwin", by Adam Goode

On 06/29/2010 07:23 AM, Andrey Kiselev wrote:

On Fri, Jun 18, 2010 at 02:35:23PM -0400, Adam Goode wrote:

+dnl Check for Win32 IO: make sure we have windows.h but not cygwin +case "${host_os}" in

+    cygwin*)
+        win32_io_ok=no

This bit seems wrong in the case where Cygwin is used to build a native Windows (MinGW) application. It is also wrong for a MinGW cross-compiler. The target OS should be what matters.

Also, there is another spot, just above in configure.ac that should be target_os, yes?

dnl We don't need to add math library to all targets case "${host_os}" in

    cygwin* | mingw32* | beos* | darwin*)

        ;;
    *)
        AC_CHECK_LIB(m,sin,,,)
        ;;
esac

No, it was correctly done here and your patch was correct too. There is a quote from autobook:

"When building cross compilation tools, there are two different systems involved: the system on which the tools will run, and the system for which the tools will generate code. The system on which the tools will run is called the host system. The system for which the tools generate code is called the target system.

For example, suppose you have a compiler which runs on a GNU/Linux system and generates ELF programs for a MIPS-based embedded system. In this case, the GNU/Linux system is the host, and the MIPS ELF system is the target. Such a compiler could be called a GNU/Linux cross MIPS ELF compiler, or, equivalently, a `i386-linux-gnu' cross `mips-elf' compiler. We discussed the latter sorts of names earlier; see 3.4 Configuration Names.

Naturally, most programs are not cross compilation tools. For those programs, it does not make sense to speak of a target. It only makes sense to speak of a target for programs like the GNU compiler or the GNU binutils which actually produce running code. For example, it does not make sense to speak of the target of a program like make."

Aha! I think you're right, thanks! I'll file a bugzilla report with the original patch.

Adam