2021.01.16 01:12 "Re: [Tiff] MergeRequest for discussion code style", by Edward Lam
Thoughts on these changes?
I'm merely a library user bystander but I have my own biases on such matters so I'm going to express my personal opinion. :)
- Widespread code formatting changes should be in their own commit and not mixed with other changes. Ideally, independent commits for changing all the whitespace and reordering of functions.
- Using `long` is WRONG (rhyme intended). If you're in the Unix world, that's fine but as soon as you go to Windows (and possibly on other OSes), sizeof(long) == sizeof(int) == 4 regardless of whether you're compiling as a 32-bit or 64-bit process. If the intention here is to use a signed integer type that is 32-bit on 32-bit processes and 64-bit on 64-bit processes, then the right type might be `intptr_t` for C99. (Although I personally like the POSIX idea of `ssize_t` better but I forget whether that's available on Windows).
My 2 cents,