2021.05.06 02:09 "[Tiff] Use and implementation of Deflate vs. AdobeDeflate in libtiff", by David Ryskalczyk

2021.05.06 13:18 "Re: [Tiff] Use and implementation of Deflate vs. AdobeDeflate in libtiff", by David Ryskalczyk

Hi,

My first reaction would be that it's an overlook. Each place where we test for COMPRESS_DEFLATE we should also test for COMPRESS_ADOBE_DEFLATE and vice versa. Could you issue a merge request fixing the mismatches you spotted

I just did so at https://gitlab.com/libtiff/libtiff/-/merge_requests/245.

Would be a bit extreme, but we could emit a non-fatal warning (using TIFFWarningExt()

I added a non-fatal warning in TIFFInitZIP() but it shows when a file is opened, not just when one is written. Is this preferred? I'm not sure how to do the latter.

I also made it so that all tools output in COMPRESS_ADOBE_DEFLATE format when zip format is requested, as some tools still used the legacy identifier, and I've run into problems with tiff2pdf-generated PDFs due to this.

David