2020.12.19 20:37 "[Tiff] tiffcp - Make the display of compression options conditional", by Miguel Medalha

2020.12.19 21:31 "Re: [Tiff] tiffcp - Make the display of compression options conditional", by Bob Friesenhahn

The current display of parameters for tiffcp is hardcoded in tiffcp.c. Even when certain compression libraries are not built, tiffcp will display all the options, including the non-functioning ones, which to me seems very inelegant.

Agreed.

I propose making the display conditional upon the real support for those options. Something like the following (starting at line 473 of tiffcp.c):

It would be better to use the TIFFIsCODECConfigured() function to test if a codec is supported rather than using something hard-coded since the tiff library may be updated without updating the utility.

I don't quite know what to make of the "-c sgilog" option, though. Is it an inbuilt function?

Yes.

Bob

Bob Friesenhahn
bfriesen@simple.dallas.tx.us, http://www.simplesystems.org/users/bfriesen/
GraphicsMagick Maintainer, http://www.GraphicsMagick.org/
Public Key, http://www.simplesystems.org/users/bfriesen/public-key.txt