AWARE SYSTEMS
TIFF and LibTiff Mail List Archive

Thread

1994.11.18 13:16 "beta021 compiler warnings on Amiga SAS/C 6.50", by Harald Fricke
1994.11.18 17:12 "Re: beta021 compiler warnings on Amiga SAS/C 6.50", by Sam Leffler
1994.11.18 23:42 "Re: beta021 compiler warnings on Amiga SAS/C 6.50", by Alex Kiernan

1994.11.18 13:16 "beta021 compiler warnings on Amiga SAS/C 6.50", by Harald Fricke

Dear Sam,

I am trying to convert the TIFF library to late Commodore-Amiga's native operating system. Here is a list of things the SAS/C 6.50 compiler was unhappy about. I admit that these are mostly cosmetic changes, but I would appreciate if I could just compile the sources without any warnings.

mkg3states.c 580: expression returned from find_null_mode_prefix()
                  should be cast to short.
mkg3states.c 605: expression returned from find_horiz_mode_prefix()
                  should be cast to short.
mkg3states.c 626: expression returned from find_uncomp_mode_prefix()
                  should be cast to short.
mkg3states.c 677: expression returned from uncomp_mode_type()
                  should be cast to short.

tif_fax3.c 312, 321: fillspan() stores 0xff into chars which is out of
                      range for signed 8-bit chars.

tif_getimage.c, tiff_lzw.c: tons of warnings about macro invocations that may
                            have multiple side effects.

tif_open.c 285: expression returned from TIFFScanlineSize() evaluates to
                unsigned long and should be cast to tsize_t (which is
                deliberately made signed according to the comments).

tif_strip.c 101, 104: expressions returned from TIFFVStripSize() evaluate
                      to unsigned long and should be cast to tsize_t.

tif_tile.c 143, 180: some expressions returned from TIFFTileRowSize() and
                     TIFFVTileSize() evaluate to unsigned long and should
                     be cast to tsize_t.

tif_unix.c 58: moving the include for <sys/stat.h> to the top of the file
               could unobtrusively fix a broken <sys/types.h> that does not
               define off_t.

I have noticed a lot of elaborate code in tif_atari.c handling lseeks past the current end-of-file. I'd like to know under what circumstances libtiff extends a file in this way because the Amiga I/O system does not allow this either. Are the library routines prepared to handle an error return from _tiffSeekProc() in this case? I remember the F2C run-time library failing at this point :).

Yours,
      Harald Fricke

--
Harald Fricke   FRICKE@DHVMHH1.BITNET    * "I met someone who looks a lot like
Working but not officially speaking for: *  you, she does the things you do,
Medizinische Hochschule Hannover         *  but she is an IBM"
D-30623 Hannover, Germany                *  E.L.O.  _Yours_Truly,2095_