AWARE SYSTEMS
TIFF and LibTiff Mail List Archive

Thread

2021.03.06 22:15 "[Tiff] Libdeflate not found ?", by Miguel Medalha
2021.03.06 22:31 "Re: [Tiff] Libdeflate not found ?", by Roger Leigh
2021.03.06 22:59 "Re: [Tiff] Libdeflate not found ?", by Miguel Medalha
2021.03.06 23:17 "Re: [Tiff] Libdeflate not found ?", by Miguel Medalha
2021.03.07 14:34 "Re: [Tiff] Libdeflate not found ?", by Roger Leigh
2021.03.07 15:44 "Re: [Tiff] Libdeflate not found ?", by Miguel Medalha
2021.03.07 15:48 "Re: [Tiff] Libdeflate not found ?", by Roger Leigh

2021.03.07 14:34 "Re: [Tiff] Libdeflate not found ?", by Roger Leigh

Looks like we have two issues here:

1 – libdeflate is automatically found if renamed to ‘deflate.lib’ only. This was previously dealt with by this code in CMakeTexts.txt:

# libdeflate
(…)
set(DEFLATE_NAMES ${DEFLATE_NAMES} deflate libdeflate libdeflatestatic)

Please note that the default Windows build for the released deflate library produces “libdeflatestatic.lib”.

2 – Specifying the location manually only works with “-DDeflate_LIBRARY” (lowercase). This goes against all other cases, including “-DDEFLATE_INCLUDE_DIR”, which still works in uppercase. This is not consistent.

So there shouldn’t have been any change to the library naming. We now search for:

set(Deflate_NAMES deflate deflatestatic)
set(Deflate_NAMES_DEBUG deflated deflatestaticd)

The change here is dropping “libdeflate”. But since the find_library call will add the “lib” prefix automatically, that should not have changed the behaviour.

Regarding the use of cases, please see the comments in the merge request I pointed to; this matches the upstream CMake naming conventions.

Please could you show us:

  1. The location and naming of the deflate .lib and .dll (if appropriate) files on your system
  2. The CMakeCache, CMakeOutput and CMakeError
  3. Your environment
  4. The full CMake command-line

There is clearly something not quite right here, but the intention is that all of the detection is completely transparent. Once we are happy it’s working portably, my intention is to submit these upstream for general use.

Regards,

Roger